Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update service's image on docker/nwm_gui/docker-compose.yml #379

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Update service's image on docker/nwm_gui/docker-compose.yml #379

merged 1 commit into from
Jul 10, 2023

Conversation

viktoriussuwandi
Copy link
Contributor

issue#201

Additions

Removals

Changes

Hi aaraney,
just trying to help on this issue on file docker/nwm_gui/docker-compose.yml, please check it out

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • No linting errors or warnings

aaraney
aaraney approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@aaraney aaraney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @viktoriussuwandi!

@aaraney aaraney merged commit 8957ca7 into NOAA-OWP:master Jul 10, 2023
1 check passed
@aaraney aaraney mentioned this pull request Jul 10, 2023
Merged
@viktoriussuwandi viktoriussuwandi deleted the issue#201 branch July 11, 2023 05:33
@aaraney aaraney mentioned this pull request Jul 24, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaraney aaraney aaraney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viktoriussuwandi @aaraney